return, not next, from eval BLOCK user/dbs/return_from_eval
authorDan Scott <dscott@laurentian.ca>
Fri, 21 Jun 2013 03:39:21 +0000 (23:39 -0400)
committerDan Scott <dscott@laurentian.ca>
Fri, 21 Jun 2013 03:39:21 +0000 (23:39 -0400)
commitcd396550b98fcd2a6bbba0154d2504bfca9c5758
tree774a37daf60ef4780ae53448b69741d8e091ed1d
parentadba9bf5b841e3b38cb78002db94b341fa9ce78b
return, not next, from eval BLOCK

Per perldoc eval, exiting an eval BLOCK is not allowed. And it generates
warnings - 37,000 of them in one day - on a system on which the fine
generator runs every 15 minutes. Simply returning from the block
achieves the same goal without generating scads of warnings.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm