LP 1827250: Fix Last Captured Hold Check for Holds Shelf user/dyrcona/lp1827250_last_captured_hold_fix
authorJason Stephenson <jason@sigio.com>
Wed, 1 May 2019 18:19:06 +0000 (14:19 -0400)
committerJason Stephenson <jason@sigio.com>
Wed, 1 May 2019 18:19:06 +0000 (14:19 -0400)
commit9ad7a253c183e0e9d9516d79924484725da7b24e
tree484fcadf4157fc8ca1d8581c0832d98e68a83a36
parent39f15482ebfdb7933701d9ce9db8d1e64d4d2184
LP 1827250: Fix Last Captured Hold Check for Holds Shelf

When the current copy on an on shelf hold is the same as that on some
uncaptured holds, the hold fails to appear on the hold shelf when it
should.  This comes down to some SQL in the storage function to
retrieve wide holds: open-ils.storage.action.live_holds.wide_hash.

The intent of the new code is to check that the current hold matches
the most recently captured hold for the copy.  However, it fails to
take into account that non-captured holds could have the same current
copy as the presently captured and on shelf hold.  This patch
rectifies this by limiting the check to captured holds.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm