LP#1568195: fix retrieving big OUS batches user/gmcharlt/lp1568195_retrieve_big_ous_batches_pr
authorGalen Charlton <gmc@esilibrary.com>
Sat, 9 Apr 2016 01:46:35 +0000 (21:46 -0400)
committerGalen Charlton <gmc@esilibrary.com>
Sat, 9 Apr 2016 01:46:35 +0000 (21:46 -0400)
commitdb40c6513eb5909e281a74b828f82d2282783af7
tree7840583e70f76f2a2aa4a2ed8dfd57e3ef2827a6
parentb36c80aaf410f54792bdd57b0c15f634566af50d
LP#1568195: fix retrieving big OUS batches

This patch fixes a regression introduced in LP#1501471
where the Library Settings Editor could fail to retrieve
the values of org unit settings if more than 99 were
requested at a time.

To test
-------
[1] Open the XUL library settings editor and ensure that
    no search filters are in effect. Note that values
    are not displayed for any of the OU settings, and that
    the Pg log contains error messages like this:

    "ERROR: cannot pass more than 100 arguments to a function"

[2] Apply the patch.
[3] Repeat step one, and verify that values are now retrieved
    for all of the OU settings that have values set.
[4] Verify that the pgTAP tests in live_t/aous_batch.pg pass.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm
Open-ILS/src/sql/Pg/020.schema.functions.sql
Open-ILS/src/sql/Pg/live_t/aous_batch.pg
Open-ILS/src/sql/Pg/upgrade/XXXX.schema.make_ous_batch_retrieve_func_nonvariadic.sql [new file with mode: 0644]