LP#1642344: XUL report cloning user/gmcharlt/lp1642344_xul_report_cloning
authorGalen Charlton <gmc@equinoxinitiative.org>
Fri, 29 Jun 2018 18:45:27 +0000 (14:45 -0400)
committerGalen Charlton <gmc@equinoxinitiative.org>
Fri, 10 Aug 2018 21:57:30 +0000 (17:57 -0400)
commitb398fc523a5874826dd65353547461dfdedf3a0e
tree0d45eee3bc18cafbaca5bdd93c64ee559c5f2ce9
parente3a67f1a81b8e7ffd3a856c2addd2c0a3a8486a7
LP#1642344: XUL report cloning

This patch allows report templates of version 4 and earlier
(which would have been created by the XUL staff client) to
be upgraded to template version 5 (used by the web staff
client) when the user clones a report. This closes a limitation
introduced in the reporter module for the web staff client.

Note that during the conversion, inner joins are used by
default when IDL classes have a 'has_a' relation rather than
defaulting to left outer joins, improving correctness of the
generated SQL query.

To test
-------
[0] Apply the patch.
[1] In a test database that has reporter templates created
    by (or for) the XUL staff client, create clones of
    those templates.
[2] Verify that the output of reports created using the new
    templates matches output of reports from the original
    templates.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Open-ILS/web/js/ui/default/staff/reporter/template/app.js
Open-ILS/web/js/ui/default/staff/test/unit/egReporter.js
Open-ILS/web/reports/oils_rpt_folder_window.js