Lp 1835620: Require some Storage submodules instead of use them user/gmcharlt/lp1835620_signoff
authorJason Stephenson <jason@sigio.com>
Sun, 7 Jul 2019 11:18:01 +0000 (07:18 -0400)
committerGalen Charlton <gmc@equinoxinitiative.org>
Fri, 2 Aug 2019 14:06:20 +0000 (10:06 -0400)
commitdcba4cbebd00d667603414be9828968db669c867
tree78d08f336eb6143c135dc826f52f918f4b15d80e
parentd5053483e2fe20c5d5273930a62993d3aa9e9179
Lp 1835620: Require some Storage submodules instead of use them

Switch from "use" to "require" for submodules in OpenILS::Application
::Storage::CDBI and OpenILS::Application::Storage::Driver::Pg.
Circular dependencies and other issues cause the following errors at
compile time for those modules:

Compilation failed in require at
/usr/local/share/perl/5.28.1/OpenILS/Application/Storage/CDBI.pm line
9.

Compilation failed in require at
/usr/local/share/perl/5.26.1/OpenILS/Application/Storage/Driver/Pg.pm
line 15.

Require loads the submodules at run time and does not attempt to
import any methods.  This is the behavior we want, eliminates the
above errors, and everything still works.

Add comments above the required modules explaining why require is
needed and not use.

Enable and reorder all of the tests in Open-ILS/src/perlmods/t/
09-OpenILS-Application-Storage-Driver.t.  Repairing the above issue
also repairs these tests.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI.pm
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg.pm
Open-ILS/src/perlmods/t/09-OpenILS-Application-Storage-Driver.t