LP#1930933: fix issue with over-escaping in search results title attributes user/gmcharlt/lp1930933_reveal_what_was_hidden
authorGalen Charlton <gmc@equinoxOLI.org>
Mon, 14 Jun 2021 15:34:51 +0000 (11:34 -0400)
committerGalen Charlton <gmc@equinoxOLI.org>
Mon, 14 Jun 2021 15:34:51 +0000 (11:34 -0400)
commit90c2cfac54e8b1a58e2fe015ae6078fb26547bae
treedfbb590a203024b6c513bcad1736cb3a2c7f9090
parentaa3dbaee4b8c34aec79e752a6d94534a14394175
LP#1930933: fix issue with over-escaping in search results title attributes

This patch fixes an issue where a record with a title containing the
word "hidden" can have its title, ironically enough, not show up
on public catalog search results.

To test
-------
[1] Create an OPAC-visible record whose 245 is something like:

    =245 04$aThe hidden one <script>alert('title!')</script>

[2] Search for the record in both the TPAC and Bootstrap skin. Note
    that the title isn't displayed.
[3] Apply the patch and repeat step 2. This time, the full title
    should be displayed.
[4] Verify that the OPAC does not display an alert box.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Open-ILS/src/templates-bootstrap/opac/parts/result/table.tt2
Open-ILS/src/templates/opac/parts/result/table.tt2