LP#1993754: fix XML-RPC gateway's handling of Fieldmapper objects user/gmcharlt/lp1993754-fix-xmlrpc-fm-handling
authorGalen Charlton <gmc@equinoxOLI.org>
Thu, 20 Oct 2022 22:17:13 +0000 (18:17 -0400)
committerGalen Charlton <gmc@equinoxOLI.org>
Thu, 20 Oct 2022 22:19:43 +0000 (18:19 -0400)
commit22b26a2d13ed0c559fa84c6d65e7a76997459902
tree3e51e5dcb7b29db1249c9f6821556aa2122147e8
parentc84102daacd7ccb277c566d58cb5e387d4cf0f3e
LP#1993754: fix XML-RPC gateway's handling of Fieldmapper objects

This patch improves the handling of Fieldmapper objects by the
XML-RPC gateway by:

- enabling support for the XML-RPC nil extension, thereby allowing
  null values to be correcty passed back and forth rather than
  converting them to empty strings
- fixing the de-serialization of Fieldmapper objects; this allows
  a Fieldmapper object returned by one XML-RPC call to be modified
  and consumed by a second one

To test
-------
[1] Apply the patch but do not restart Apache.
[2] Run the new test script test-xml-rpc-patron-update.pl to
    try update a patron record; note that the update fails.
[3] Restart or reload Apache and repeat step 2; this time, the
    patron update should succeed.

Note that the test script may need minor modification to work on your
local testing environment.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
Open-ILS/src/support-scripts/test-scripts/test-xml-rpc-patron-update.pl [new file with mode: 0755]