LP#904581: when calculating hold status, be more careful about fetching transits user/gmcharlt/lp904581_comfort_confused_holds
authorGalen Charlton <gmc@esilibrary.com>
Thu, 5 Feb 2015 16:52:36 +0000 (16:52 +0000)
committerGalen Charlton <gmc@esilibrary.com>
Thu, 5 Feb 2015 16:52:36 +0000 (16:52 +0000)
commit1e20d63fd3eca8bef477bc2cbfd3dec67198a352
treef5fd79caabf4430cb34f1b20f305d1af045cba5a
parent4ef6f4bcd58e87d452e3bf0f4f01020aec57078c
LP#904581: when calculating hold status, be more careful about fetching transits

This patch fixes a problem where if a hold meets the following
criteria, an "Invalid date format: at /usr/share/perl5/Error.pm"
error can be thrown when fetching its details:

- the hold has a captured item
- the captured item has status 8 (on hold shelf)
- there is another item that is currently in transit to fill the hold
- the pickup library (or one of its ancestors) has the
  circ.hold_shelf_status_delay library setting set.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm