LP#1686194 Account for adjustments when generating fines user/jeffdavis/lp1686194_missing_adjustments_max_fines_signoff
authorDan Wells <dbw2@calvin.edu>
Mon, 24 Apr 2017 18:29:04 +0000 (14:29 -0400)
committerJeff Davis <jdavis@sitka.bclibraries.ca>
Tue, 2 May 2017 23:07:15 +0000 (16:07 -0700)
commit9777ad41926b56b261d4cc8fe8d5fddfd603fb76
tree429c3b7add6d7795bf7df724645c074889286214
parent3db63ee4835600f3938549a2df4bd1e09cd1fd4d
LP#1686194 Account for adjustments when generating fines

Fine generation stops at a predetermined 'max fines' amount, but this
does not account for possible adjustments which lower the effective
fine amount.  This situation is common in cases where lost items are
returned, and the library wants to generate additional overdues upon
that event.

With this commit, fine generation will pull in any adjustments applied
to overdue fines, and use those to offset the current total fine when
checking for max fines.

Also includes test for this condition.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
Open-ILS/src/perlmods/live_t/09-lp1198465_neg_balances.t
Open-ILS/tests/datasets/sql/neg_bal_custom_transactions.sql