LP#1424815: Cleanup/simplify perl and template user/rsteed/lp1424815_long_fields_accordion_jquery-approach
authorRemington Steed <rjs7@calvin.edu>
Fri, 23 Feb 2018 21:57:07 +0000 (16:57 -0500)
committerRemington Steed <rjs7@calvin.edu>
Fri, 23 Feb 2018 21:58:40 +0000 (16:58 -0500)
commitff93b2905502671737bf93941ff603dc0dca3b28
treea6986b252b2a2b36ac5ce8d5856c903f1a582c37
parent29f441fd552be61355512962a384c9e6411796c5
LP#1424815: Cleanup/simplify perl and template

This commit attempts to cleanup and simplify the "Read more" catalog
feature by making the following changes:

  - Simplify perl util function
    - Remove extra blank lines
    - Remove first IF branch, since rindex already covers this case
    - Remove "rest" from return value, since Kathy's changed stopped
      using it
    - Add logic to address the FIXME comment
    - Add a few code comments

  - Simplify template
    - Only split a string if feature is turned on in config settings
    - Allow, but don't require, "trunc_length" on every marc note field
    - Add a few code comments

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm
Open-ILS/src/templates/opac/parts/record/contents.tt2