LP#842991 Reports needs to error when deleting fails user/rsteed/reporter_wrongly_shows_success
authorRemington Steed <rjs7@calvin.edu>
Wed, 27 Nov 2013 14:55:35 +0000 (09:55 -0500)
committerRemington Steed <rjs7@calvin.edu>
Wed, 27 Nov 2013 15:20:50 +0000 (10:20 -0500)
commitddece872e923b74dc5cf707a2d0afc9abd699434
tree407f72448fe05c046729e77fb4f920679d841182
parent61302b72d463d035985bc34f535606742678c758
LP#842991 Reports needs to error when deleting fails

When attempting to delete a report template, the reports interface
incorrectly shows "Action Succeeded" even when it partly fails. If the
user performing the delete does not own all the dependent reports and
outputs, then the perl function returns 1 to indicate that some were
deleted, but not all. However, the javascript that calls that function
does not check for a return value of 1. This commit adds that check, and
also improves the formatting of the related error messages.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Open-ILS/web/opac/locale/en-US/reports.dtd
Open-ILS/web/reports/oils_rpt_folder_window.js