LP#1896070: ensure that deatching course material doesn't delete non-temporary bibs user/sandbergja/lp1896070_fix_course_material_detachment_signoff
authorGalen Charlton <gmc@equinoxinitiative.org>
Thu, 17 Sep 2020 14:44:01 +0000 (10:44 -0400)
committerJane Sandberg <sandbej@linnbenton.edu>
Fri, 18 Sep 2020 18:12:53 +0000 (11:12 -0700)
commit54e60cb35d20adbcc213b893af1f6bc59fb7655e
treea882d557792f5a3b2762a45a70c040b80e0d7890
parent6f73091539a6e2e2aab08ca708abaa99884c6efb
LP#1896070: ensure that deatching course material doesn't delete non-temporary bibs

This patch fixes how the temporary_record field is checked; in Perl code,
non-NULL Boolean fields in Fieldmapper objects do /not/ evaluate as
Perl Boolean values; you have to use $U->is_true() or explictly
compare against 't' and 'f'.

This patch also tweaks live_t/31-courses.t so that it can be run
repeatedly.

To test
-------
[1] Run live_t/31-courses.t repeatedly; note that it will start failing
    the second time.
[2] Reset the database and apply the patch, then repeat step 1.
[3] This time, the test should work when run repeatedly.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Open-ILS/src/perlmods/lib/OpenILS/Application/Courses.pm
Open-ILS/src/perlmods/live_t/31-courses.t