Acq: re-use more code for two ways of creating invoices (EDI and manual) user/senator/acq-edi-inv-disencumber-squash
authorLebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Wed, 20 Feb 2013 14:41:03 +0000 (09:41 -0500)
committerLebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Thu, 28 Feb 2013 20:34:43 +0000 (15:34 -0500)
commitd1edf260f7536acb3a8fbe390b32a8781e2602eb
treef7f2465df5ad2e318ae143b69dfa43fd67c07258
parent6947c7068f08ef1ad548f98530a85943561293be
Acq: re-use more code for two ways of creating invoices (EDI and manual)

This solves two problems.

 1) With EDI invoices, we had been failing to disencumber fund debits
    related to the invoiced lineitems, although that worked for manual
    invoices.
 2) With manual invoices, we would not automatically uncancel copies
    when the user decided to invoice them despite their canceled status.
    This was already working in EDI invoices though.  This is especially
    important since our schema lumps "backordered" in with "canceled,"
    and in theory backordered things do show up eventually.

There were earlier version of this commit out there with bugs that
prevented the EDI workflow from working correctly (the manual invoice
flow worked and still should).

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm
Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Invoice.pm