LP1790896: Receipt Errors with invalid emails user/stompro/lp1790896_receipt_email_signoff
authorJason Boyer <jboyer@library.in.gov>
Thu, 7 Feb 2019 18:48:13 +0000 (13:48 -0500)
committerJosh Stompro <stompro@stompro.org>
Sun, 10 Mar 2019 20:16:13 +0000 (15:16 -0500)
commit60402a289826451203df989edf02f5e3d4c20651
tree93787b49f608c9cd4482626eb661821f88424352
parent1c061dd30a02a03bfe9d8043057b28e87aa910b2
LP1790896: Receipt Errors with invalid emails

The attempt at belt-and-suspenders checking for a valid
email for use in the has_email template field sadly
causes the JS to trip over said suspenders if there is
a value in the field but it doesn't contain a '@'.

The raw return from "".match() (either an array or null)
is enough to do the right thing when converted into a
Boolean and doesn't cause the same problems.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Open-ILS/web/js/ui/default/staff/circ/patron/bills.js
Open-ILS/web/js/ui/default/staff/circ/patron/checkout.js
Open-ILS/web/js/ui/default/staff/circ/patron/items_out.js