LP1911023 Batch hold cancel refreshes before completion
authorBill Erickson <berickxx@gmail.com>
Mon, 11 Jan 2021 15:59:54 +0000 (10:59 -0500)
committerJason Boyer <JBoyer@equinoxOLI.org>
Thu, 23 Sep 2021 18:52:33 +0000 (14:52 -0400)
Ensure all hold cancelation promises complete before reporting the
results back to the caller.  Issue was result of thinko in the code
that failed to relay one of the promises in the chain, so it reported
promise completion prematurely.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Open-ILS/src/eg2/src/app/staff/share/holds/cancel-dialog.component.ts

index 2d6d790..f69b1b4 100644 (file)
@@ -84,7 +84,7 @@ export class HoldCancelDialogComponent
                     console.error(this.evt.parse(result));
                     this.toast.warning(await this.errorMsg.current());
                 }
-                this.cancelNext(ids);
+                return this.cancelNext(ids);
             }
         );
     }