Patch from Galen Charlton: removes empty controlfield elements, which can be produced...

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15860 dcc99617-32d9-48b4-a31d-7c20da2025e4

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Cat/BibCommon.pm b/Open-ILS/src/perlmods/OpenILS/Application/Cat/BibCommon.pm
index a60fce4..8cebc57 100644 (file)
--- a/Open-ILS/src/perlmods/OpenILS/Application/Cat/BibCommon.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Cat/BibCommon.pm
@@ -123,6 +123,11 @@ sub __make_marc_doc {
        my $marcxml = XML::LibXML->new->parse_string($xml);
        $marcxml->documentElement->setNamespace($MARC_NAMESPACE, "marc", 1 );
        $marcxml->documentElement->setNamespace($MARC_NAMESPACE);
+       # remove empty control fields - at least one source of records adds ersatz blank 008s
+       # that become empty controlfield elements
+       foreach my $controlfield ($marcxml->documentElement->getElementsByTagNameNS($MARC_NAMESPACE, 'controlfield')) {
+               $controlfield->parentNode->removeChild($controlfield) unless $controlfield->hasChildNodes();
+       }
        return $marcxml;
 }