add detail to some error logs. add a few info logs to help detect where we are in...

git-svn-id: svn://svn.open-ils.org/ILS/trunk@14766 dcc99617-32d9-48b4-a31d-7c20da2025e4

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Trigger.pm b/Open-ILS/src/perlmods/OpenILS/Application/Trigger.pm
index c52b0ca..951bc2c 100644 (file)
--- a/Open-ILS/src/perlmods/OpenILS/Application/Trigger.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Trigger.pm
@@ -459,6 +459,7 @@ sub fire_single_event {
     my $e = OpenILS::Application::Trigger::Event->new($event_id);
 
     if ($e->validate->valid) {
+        $logger->info("Event is valid, reacting...");
         $e->react->cleanup;
     }
 
@@ -486,6 +487,7 @@ sub fire_event_group {
     my $e = OpenILS::Application::Trigger::EventGroup->new(@$events);
 
     if ($e->validate->valid) {
+        $logger->info("Event group is valid, reacting...");
         $e->react->cleanup;
     }
 

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Trigger/Event.pm b/Open-ILS/src/perlmods/OpenILS/Application/Trigger/Event.pm
index 0d69627..2f17d25 100644 (file)
--- a/Open-ILS/src/perlmods/OpenILS/Application/Trigger/Event.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Trigger/Event.pm
@@ -2,7 +2,7 @@ package OpenILS::Application::Trigger::Event;
 use strict; use warnings;
 use OpenSRF::EX qw/:try/;
 
-use OpenSRF::Utils::Logger qw/:logger/;
+use OpenSRF::Utils::Logger qw/$logger/;
 
 use OpenILS::Utils::Fieldmapper;
 use OpenILS::Utils::CStoreEditor q/:funcs/;
@@ -113,7 +113,7 @@ sub cleanup {
                 $self->cleanedup(1);
             }
         } otherwise {
-            $log->error( shift() );
+            $log->error("Event cleanup failed with ". shift() );
             $self->update_state( 'error' ) || die 'Unable to update event state';
         };
 
@@ -148,7 +148,7 @@ sub react {
                         ->final_result
                 );
             } otherwise {
-                $log->error( shift() );
+                $log->error("Event reacting failed with ". shift() );
                 $self->update_state( 'error' ) || die 'Unable to update event state';
             };
 
@@ -179,7 +179,7 @@ sub validate {
                     ->final_result
             );
         } otherwise {
-            $log->error( shift() );
+            $log->error("Event validation failed with ". shift() );
             $self->update_state( 'error' ) || die 'Unable to update event state';
         };
 

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Trigger/EventGroup.pm b/Open-ILS/src/perlmods/OpenILS/Application/Trigger/EventGroup.pm
index 41ce3b9..4cd10e1 100644 (file)
--- a/Open-ILS/src/perlmods/OpenILS/Application/Trigger/EventGroup.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Trigger/EventGroup.pm
@@ -4,7 +4,7 @@ use OpenILS::Application::Trigger::Event;
 use base 'OpenILS::Application::Trigger::Event';
 use OpenSRF::EX qw/:try/;
 
-use OpenSRF::Utils::Logger qw/:level/;
+use OpenSRF::Utils::Logger qw/$logger/;
 
 use OpenILS::Utils::Fieldmapper;
 use OpenILS::Utils::CStoreEditor q/:funcs/;
@@ -56,7 +56,7 @@ sub react {
                     ->final_result
             );
         } otherwise {
-            $log->error( shift() );
+            $log->error("Event reacting failed with ". shift() );
             $self->update_state( 'error' ) || die 'Unable to update event group state';
         };
 
@@ -90,7 +90,7 @@ sub validate {
         $self->{ids} = [ map { $_->id } @valid_events ];
         $self->editor->xact_commit;
     } otherwise {
-        $log->error( shift() );
+        $log->error("Event group validation failed with ". shift() );
         $self->editor->xact_rollback;
         $self->update_state( 'error' ) || die 'Unable to update event group state';
     };