Remove C compiler warning for writeAuditInfo collab/dyrcona/lp1043633
authorDan Scott <dscott@laurentian.ca>
Thu, 30 Aug 2012 04:21:01 +0000 (00:21 -0400)
committerJason Stephenson <jstephenson@mvlc.org>
Sat, 6 Oct 2012 17:19:33 +0000 (13:19 -0400)
The C compiler was throwing the following warning:

oils_sql.c: In function 'writeAuditInfo':
oils_sql.c:7244:1: warning: control reaches end of non-void function
[-Wreturn-type]

By shifting the "return 0" to the end of the function, outside of the if
statements, we can ensure that we always return an int value.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Open-ILS/src/c-apps/oils_sql.c

index 5bc76b1..e0500d2 100644 (file)
@@ -7235,9 +7235,9 @@ int writeAuditInfo( osrfMethodContext* ctx, const char* user_id, const char* ws_
                        return -1;
                } else {
                        dbi_result_free( result );
-                       return 0;
                }
        }
+       return 0;
 }
 
 /*@}*/