fixed a broken order_by statement and cleaned up a boolean test
authorerickson <erickson@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Thu, 14 Dec 2006 14:24:45 +0000 (14:24 +0000)
committererickson <erickson@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Thu, 14 Dec 2006 14:24:45 +0000 (14:24 +0000)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@6704 dcc99617-32d9-48b4-a31d-7c20da2025e4

Open-ILS/src/perlmods/OpenILS/Application/Circ/Holds.pm

index d9d2f83..58890b1 100644 (file)
@@ -831,7 +831,7 @@ sub flesh_hold_notices {
                my $notices = $e->search_action_hold_notification(
                        [
                                { hold => $hold->id },
-                               { order_by => { anh => { 'notify_time desc' } } },
+                               { order_by => { anh => 'notify_time desc' } },
                        ],
                        {idlist=>1}
                );
@@ -944,9 +944,7 @@ sub check_title_hold {
                        $e->allowed('VIEW_HOLD_PERMIT', $patron->home_ou);
        }
 
-       return OpenILS::Event->new('PATRON_BARRED') 
-               if $patron->barred and 
-                       ($patron->barred =~ /t/i or $patron->barred == 1);
+       return OpenILS::Event->new('PATRON_BARRED') if $U->is_true($patron->barred);
 
        my $rangelib    = $params{range_lib} || $patron->home_ou;