don't die silently, let's log some error output to look for patterns

git-svn-id: svn://svn.open-ils.org/ILS/trunk@14765 dcc99617-32d9-48b4-a31d-7c20da2025e4

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Trigger.pm b/Open-ILS/src/perlmods/OpenILS/Application/Trigger.pm
index 5a4f6cf..c52b0ca 100644 (file)
--- a/Open-ILS/src/perlmods/OpenILS/Application/Trigger.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Trigger.pm
@@ -536,13 +536,20 @@ sub grouped_events {
         my $e;
         try {
            $e = OpenILS::Application::Trigger::Event->new($e_id);
-        } otherwise {};
+        } catch Error with {
+            $logger->error("Event creation failed with ".shift());
+        };
 
         next unless $e; 
+        my $valid;
 
-        if (try { $e->validate->valid } otherwise { $e = undef; }) {
+        try {
+            $valid = $e->validate->valid;
+        } catch Error with {
+            $logger->error("Event validation failed with ".shift());
+        };
 
-            next unless $e;
+        if ($valid) {
 
             if (my $group = $e->event->event_def->group_field) {
 
@@ -591,9 +598,8 @@ sub run_all_events {
                             ->method_lookup('open-ils.trigger.event.fire')
                             ->run($event)
                     );
-                } otherwise { 
-                    # un-oh
-                    $logger->error("event firing failed");
+                } catch Error with { 
+                    $logger->error("event firing failed with ".shift());
                 };
             }
         } else {
@@ -605,9 +611,8 @@ sub run_all_events {
                             ->method_lookup('open-ils.trigger.event_group.fire')
                             ->run($$defgroup{$ident})
                     );
-                } otherwise {
-                    # uh-oh
-                    $logger->error("event group firing failed");
+                } catch Error with {
+                    $logger->error("event firing failed with ".shift());
                 };
             }
         }