LP#854760 messagecat fails with certain 404 pages

We were failing to check the HTTP status on the underlying XHR requests.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

diff --git a/Open-ILS/xul/staff_client/chrome/content/main/bindings.xml b/Open-ILS/xul/staff_client/chrome/content/main/bindings.xml
index 6eae692..364184c 100644 (file)
--- a/Open-ILS/xul/staff_client/chrome/content/main/bindings.xml
+++ b/Open-ILS/xul/staff_client/chrome/content/main/bindings.xml
@@ -179,7 +179,7 @@
                             var x = new XMLHttpRequest();
                             x.open("GET",this.src,false);
                             x.send(null);
-                            if (x.responseText) {
+                            if (x.status == 200 && x.responseText) {
                                 var props = this._props2object(x.responseText);
                                 for (var i in props) {
                                     this._props[i] = props[i];
@@ -194,7 +194,7 @@
                                 var x2 = new XMLHttpRequest();
                                 x2.open("GET",custom_src,false);
                                 x2.send(null);
-                                if (x2.responseText) {
+                                if (x2.status == 200 && x2.responseText) {
                                     var props = this._props2object(x2.responseText);
                                     for (var i in props) {
                                         this._props[i] = props[i];