LP#1970486: fix SuperCat crash on serial units with stat cats
authorGalen Charlton <gmc@equinoxOLI.org>
Tue, 26 Apr 2022 21:33:18 +0000 (17:33 -0400)
committerMike Rylander <mrylander@gmail.com>
Wed, 27 Apr 2022 14:11:58 +0000 (10:11 -0400)
This patch fixes a bug where retrieving a title via SuperCat (in
particular, with holdings XML) can crash of the title has a serial
unit (i.e., barcoded serial item) attached that also has a statistical
category.

To test
-------
[1] Create a title with a barcoded serial item.
[2] Attempt to fetch the title via SuperCat:

https://EGSERVER/opac/extras/supercat/retrieve/marcxml-full/record/BIBID

[3] Note that an internal server error is returned.
[4] Apply the patch and repeat step 2. This time, an XML
    document should be returned that includes the serial item
    and its stat cat.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm

index 8aac6ab..3a442af 100644 (file)
@@ -2403,6 +2403,7 @@ sub new_record_holdings {
                     sstr    => [qw/items/],
                     sitem   => [qw/notes unit/],
                     sunit   => [qw/notes location status circ_lib stat_cat_entries call_number/],
+                    asce    => [qw/stat_cat/],
                     acn => [qw/owning_lib prefix suffix/],
                 },
           ( $limit > -1 ? ( limit  => $limit  ) : () ),