LP1895660: Search/Authority.pm

Argument "" isn't numeric in numeric ne (!=)

One of the "fun" things about perl and its type system is that
it uses different operators to compare strings vs comparing numbers...

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Authority.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Authority.pm
index 2778912..93b1ab1 100644 (file)
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Authority.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Authority.pm
@@ -76,7 +76,7 @@ sub search_authority_by_simple_normalize_heading {
     my $e = new_editor();
     my $norm_heading = $e->json_query($norm_heading_query)->[0]->{'authority.simple_normalize_heading'};
 
-    unless (defined($norm_heading) && $norm_heading != '') {
+    unless (defined($norm_heading) && $norm_heading ne '') {
         return OpenILS::Event->new('BAD_PARAMS', note => 'Heading normalized to null or empty string');
     }