Fix some "null" instead of blank values in JSPac

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

diff --git a/Open-ILS/web/opac/skin/default/js/holds.js b/Open-ILS/web/opac/skin/default/js/holds.js
index f9a9751..e40f29c 100644 (file)
--- a/Open-ILS/web/opac/skin/default/js/holds.js
+++ b/Open-ILS/web/opac/skin/default/js/holds.js
@@ -592,7 +592,7 @@ function __holdsDrawWindow() {
        }
 
 
-       $('holds_phone').value = holdArgs.recipient.day_phone();
+       $('holds_phone').value = (holdArgs.recipient.day_phone() ? holdArgs.recipient.day_phone() : '');
        appendClear( $('holds_email'), text(holdArgs.recipient.email()));
 
        var pref = holdArgs.recipient.prefs[PREF_HOLD_NOTIFY];

diff --git a/Open-ILS/web/opac/skin/default/js/myopac.js b/Open-ILS/web/opac/skin/default/js/myopac.js
index 925997a..165376e 100644 (file)
--- a/Open-ILS/web/opac/skin/default/js/myopac.js
+++ b/Open-ILS/web/opac/skin/default/js/myopac.js
@@ -869,9 +869,11 @@ function _myOPACSummaryShowUer(r) {
         unHideMe($('myopac.expired.alert'));
     }
 
-       var iv1 = user.ident_value()+'';
-    if (iv1.length > 4 && iv1.match(/\d{4}/)) iv1 = iv1.substring(0,4) + '***********';
-
+       var iv1 = '';
+    if (user.ident_value()) {
+        iv1 = user.ident_value()+'';
+        if (iv1.length > 4 && iv1.match(/\d{4}/)) iv1 = iv1.substring(0,4) + '***********';
+    }
 
        appendClear($('myopac_summary_prefix'),text(user.prefix()));
        appendClear($('myopac_summary_first'),text(user.first_given_name()));