Holds placement avoid calling non-existent func.
authorBill Erickson <berickxx@gmail.com>
Mon, 15 Dec 2014 20:08:06 +0000 (15:08 -0500)
committerBill Erickson <berickxx@gmail.com>
Thu, 21 Mar 2019 19:46:23 +0000 (15:46 -0400)
Avoid calling an undefined function during hold placement.  In older
versions of opensrf, this kind of the thing would silently fail.  (Well,
it would log to the stderr file).  Modern opensrf allows Perl the throw
a standard exception, which stops execution.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm

index b853b42..7d405ab 100644 (file)
@@ -396,7 +396,7 @@ sub create_hold {
         'open-ils.hold-targeter.target', {hold => $hold->id}
     ) unless $U->is_true($hold->frozen);
 
-    $U->log_user_activity($recipient->id, $self->get_act_who, 'hold');
+    $U->log_user_activity($recipient->id, '', 'hold');
     return undef;
 }