LP1904036 Auto-print holds/transits checkin mod fix
authorBill Erickson <berickxx@gmail.com>
Thu, 7 Oct 2021 14:42:57 +0000 (10:42 -0400)
committerGalen Charlton <gmc@equinoxOLI.org>
Fri, 28 Oct 2022 00:13:38 +0000 (20:13 -0400)
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Open-ILS/src/eg2/src/app/staff/share/circ/circ.service.ts
Open-ILS/src/eg2/src/app/staff/share/circ/route-dialog.component.ts

index c1b0983..c7ddd3b 100644 (file)
@@ -170,7 +170,7 @@ export interface CheckinParams {
     copy_barcode?: string;
     claims_never_checked_out?: boolean;
     void_overdues?: boolean;
-    auto_print_hold_transits?: boolean;
+    auto_print_holds_transits?: boolean;
     backdate?: string;
     capture?: string;
     next_copy_status?: number[];
@@ -380,6 +380,11 @@ export class CircService {
         const remove = Object.keys(apiParams).filter(k => k.match(/^_/));
         remove.forEach(p => delete apiParams[p]);
 
+        // This modifier is not sent to the server.
+        // Should be _-prefixed, but we already have a workstation setting,
+        // etc. for this one.  Just manually remove it from the API params.
+        delete apiParams['auto_print_holds_transits'];
+
         return apiParams;
     }
 
index 55fad58..f9aa4de 100644 (file)
@@ -92,7 +92,7 @@ export class RouteDialogComponent extends DialogComponent {
             });
         }
 
-        if (this.checkin.params.auto_print_hold_transits
+        if (this.checkin.params.auto_print_holds_transits
             || this.circ.suppressCheckinPopups) {
             // Print and exit.
             return this.print().then(_ => true); // exit