LP#1616220 Fixes for css errors that show up in the xul staff client console.

To test
-------
[1] In the XUL client, try various interfaces including acquisitions,
    the patron editor, the reporter, the library settings editor,
    serials management and patron surveys. Using the error console,
    verify that applying this patch slightly reduces the number of
    CSS warnings reported.
[2] Repeat step 1 using the web staff client, in particular while
    looking at the embedded acquisitions interfaces.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

diff --git a/Open-ILS/src/templates/acq/lineitem/findbib.tt2 b/Open-ILS/src/templates/acq/lineitem/findbib.tt2
index 42aeaff..88ce8df 100644 (file)
--- a/Open-ILS/src/templates/acq/lineitem/findbib.tt2
+++ b/Open-ILS/src/templates/acq/lineitem/findbib.tt2
@@ -53,7 +53,7 @@
         left:200px;
         bottom:100px;
         border: 3px solid #333;
-        -moz-border-radius: 5px;
+        border-radius: 5px;
         padding: 30px;
         text-align:center;
         background: #FFF;

diff --git a/Open-ILS/web/css/skin/default.css b/Open-ILS/web/css/skin/default.css
index 63bed99..b925582 100644 (file)
--- a/Open-ILS/web/css/skin/default.css
+++ b/Open-ILS/web/css/skin/default.css
@@ -93,7 +93,7 @@ table { border-collapse: collapse; }
 }
 .oils-fm-edit-dialog td { border:1px solid #999;}
 .oils-pcrudfilterdialog-table tr td { padding: 0.75ex 0.5em; }
-.oils-pcrudfilterdialog-table tr:nth-child(event) {
+.oils-pcrudfilterdialog-table tr:nth-child(even) {
     background-color: #d7d7d7;
 }
 .oils-pcrudfilterdialog-remover-holder {

diff --git a/Open-ILS/web/css/skin/default/acq.css b/Open-ILS/web/css/skin/default/acq.css
index 1dd1ccb..928bcb9 100644 (file)
--- a/Open-ILS/web/css/skin/default/acq.css
+++ b/Open-ILS/web/css/skin/default/acq.css
@@ -147,7 +147,7 @@ label[for="attr_search_type_scalar"] { vertical-align: top; }
 #acq-lit-info-tbody td {padding:5px;}
 #acq-lit-info-related { margin-top: 10px; }
 #acq-lit-distrib-formula-table { margin-top: 10px; margin-bottom: 5px;}
-#acq-lit-li-details-table {margin-top:5px; border-top;}
+#acq-lit-li-details-table {margin-top:5px;}
 #acq-lit-li-details-table td {padding:0px 3px 1px 3px;}
 #acq-lit-li-details-table th {padding:0px 3px 1px 3px; font-weight:bold;}
 #acq-lit-li-details-table .dijit {width:130px;}
@@ -175,9 +175,9 @@ span[name="worksheet"] { padding: 0 6px; }
 
 .acq-menu-bar {width:99%; text-align:left; border:1px solid #aaa; margin:5px 0px 10px 0px;}
 .acq-notes-note-row { margin: 6px 0; }
-#acq-po-notes-tbody li { margin-bottom:10px; border:1px solid #aaa; -moz-border-radius: 5px 5px 5px 5px; }
+#acq-po-notes-tbody li { margin-bottom:10px; border:1px solid #aaa; border-radius: 5px 5px 5px 5px; }
 #acq-po-notes-tbody td {padding: 20px 10px 20px 10px; border-bottom:2px solid #aaa;}
-#acq-lit-notes-tbody li { margin-bottom:10px; border:1px solid #aaa; -moz-border-radius: 5px 5px 5px 5px; }
+#acq-lit-notes-tbody li { margin-bottom:10px; border:1px solid #aaa; border-radius: 5px 5px 5px 5px; }
 #acq-lit-notes-tbody td {padding: 20px 10px 20px 10px; border-bottom:2px solid #aaa;}
 #acq-lit-alert-value { height: 5em; width: 20em; }
 span[name="vendor_public"] {color: #00c;padding-right: 1em;font-weight: bold;}

diff --git a/Open-ILS/web/css/skin/default/register.css b/Open-ILS/web/css/skin/default/register.css
index 4c58059..6202376 100644 (file)
--- a/Open-ILS/web/css/skin/default/register.css
+++ b/Open-ILS/web/css/skin/default/register.css
@@ -14,7 +14,7 @@
     right:30px;
     width:200px;
     border:2px solid #d9e8f9;
-    -moz-border-radius: 10px;
+    border-radius: 10px;
     font-weight: bold;
     padding: 12px;
     text-align:center;
@@ -27,7 +27,7 @@
     right:30px;
     width:300px;
     border:2px dashed #d9e8f9;
-    -moz-border-radius: 10px;
+    border-radius: 10px;
     font-weight: bold;
     padding: 20px;
     margin-top: 20px;
@@ -39,7 +39,7 @@
     right:30px;
     width:300px;
     border:2px dashed #d9e8f9;
-    -moz-border-radius: 10px;
+    border-radius: 10px;
     font-weight: bold;
     padding: 20px;
 }
@@ -50,14 +50,14 @@
     right:30px;
     width:300px;
     border:2px dashed #d9e8f9;
-    -moz-border-radius: 10px;
+    border-radius: 10px;
     font-weight: bold;
     padding: 10px;
     text-align: center;
 }
 #uedit-address-alert-header { 
     color: red; 
-    text-decoration: italic
+    font-style: italic;
     text-align: center;
 }
 

diff --git a/Open-ILS/web/reports/oils_rpt.css b/Open-ILS/web/reports/oils_rpt.css
index 3fde850..2bbbc19 100644 (file)
--- a/Open-ILS/web/reports/oils_rpt.css
+++ b/Open-ILS/web/reports/oils_rpt.css
@@ -33,7 +33,7 @@ table { border-collapse: collapse; }
 }
 
 #oils_rpt_table tr {
-       -moz-border-radius: 5px 5px 5px 5px;    
+       border-radius: 5px 5px 5px 5px; 
 }
 
 #oils_rpt_table td {

diff --git a/Open-ILS/xul/staff_client/server/admin/org_unit_settings.xhtml b/Open-ILS/xul/staff_client/server/admin/org_unit_settings.xhtml
index e54a639..662bde0 100644 (file)
--- a/Open-ILS/xul/staff_client/server/admin/org_unit_settings.xhtml
+++ b/Open-ILS/xul/staff_client/server/admin/org_unit_settings.xhtml
@@ -55,11 +55,7 @@
                 
                 /*Standards compliant*/
                 border-bottom-left-radius:5px;
-                border-bottom-right-radius:5px;
-                
-                /*Old staff client compliant, It could be worse, we could be using IE!*/
-                -moz-border-radius-bottomleft:5px;
-                -moz-border-radius-bottomright:5px; 
+                border-bottom-right-radius:5px;                
             }
             
             .message_container {
@@ -220,4 +216,4 @@
             <div class="message" id='msgInner' ></div>
         </div>
     </body>
-</html>
\ No newline at end of file
+</html>

diff --git a/Open-ILS/xul/staff_client/server/cat/copy_editor.xul b/Open-ILS/xul/staff_client/server/cat/copy_editor.xul
index ca624f5..fdb2a66 100644 (file)
--- a/Open-ILS/xul/staff_client/server/cat/copy_editor.xul
+++ b/Open-ILS/xul/staff_client/server/cat/copy_editor.xul
@@ -63,22 +63,22 @@
             </vbox>
             <splitter id="splitter1" oils_persist="state hidden" oils_persist_peers="before_splitter1 after_splitter1"><grippy /></splitter>
             <vbox flex="1" id="after_splitter1" oils_persist="width">
-                <button style="font-weight: bold; font-size: normal" label="&staff.cat.copy_editor.identification.location.label;" accesskey="&staff.cat.copy_editor.identification.location.accesskey;" oncommand="document.getElementById('right_pane').firstChild.firstChild.focus();"/>
+                <button style="font-weight: bold; font-size: medium" label="&staff.cat.copy_editor.identification.location.label;" accesskey="&staff.cat.copy_editor.identification.location.accesskey;" oncommand="document.getElementById('right_pane').firstChild.firstChild.focus();"/>
                 <vbox id="right_pane" flex="1"/>
             </vbox>
             <splitter id="splitter2" oils_persist="state hidden" oils_persist_peers="after_splitter1 after_splitter2"><grippy /></splitter>
             <vbox flex="1" id="after_splitter2" oils_persist="width">
-                <button style="font-weight: bold; font-size: normal" label="&staff.cat.copy_editor.identification.circulation.label;" accesskey="&staff.cat.copy_editor.identification.circulation.accesskey;" oncommand="document.getElementById('right_pane2').firstChild.firstChild.focus();"/>
+                <button style="font-weight: bold; font-size: medium" label="&staff.cat.copy_editor.identification.circulation.label;" accesskey="&staff.cat.copy_editor.identification.circulation.accesskey;" oncommand="document.getElementById('right_pane2').firstChild.firstChild.focus();"/>
                 <vbox id="right_pane2" flex="1"/>
             </vbox>
             <splitter id="splitter3" oils_persist="state hidden" oils_persist_peers="after_splitter2 after_splitter3"><grippy /></splitter>
             <vbox flex="1" id="after_splitter3" oils_persist="width">
-                <button style="font-weight: bold; font-size: normal" label="&staff.cat.copy_editor.identification.miscellaneous.label;" accesskey="&staff.cat.copy_editor.identification.miscellaneous.accesskey;" oncommand="document.getElementById('right_pane3').firstChild.firstChild.focus();"/>
+                <button style="font-weight: bold; font-size: medium" label="&staff.cat.copy_editor.identification.miscellaneous.label;" accesskey="&staff.cat.copy_editor.identification.miscellaneous.accesskey;" oncommand="document.getElementById('right_pane3').firstChild.firstChild.focus();"/>
                 <vbox id="right_pane3" flex="1"/>
             </vbox>
             <splitter id="splitter4" oils_persist="state hidden" oils_persist_peers="after_splitter3 after_splitter4"><grippy /></splitter>
             <vbox flex="1" id="after_splitter4" oils_persist="width">
-                <button style="font-weight: bold; font-size: normal" label="&staff.cat.copy_editor.identification.statistics.label;" accesskey="&staff.cat.copy_editor.identification.statistics.accesskey;" oncommand="document.getElementById('right_pane4').firstChild.firstChild.focus();"/>
+                <button style="font-weight: bold; font-size: medium" label="&staff.cat.copy_editor.identification.statistics.label;" accesskey="&staff.cat.copy_editor.identification.statistics.accesskey;" oncommand="document.getElementById('right_pane4').firstChild.firstChild.focus();"/>
                 <menu label="&staff.cat.copy_editor.stat_cat_lib_filter_menu.label;" id="stat_cat_lib_filter_menu">
                     <menupopup />
                 </menu>

diff --git a/Open-ILS/xul/staff_client/server/cat/copy_notes.xul b/Open-ILS/xul/staff_client/server/cat/copy_notes.xul
index 223a069..73de71c 100644 (file)
--- a/Open-ILS/xul/staff_client/server/cat/copy_notes.xul
+++ b/Open-ILS/xul/staff_client/server/cat/copy_notes.xul
@@ -206,7 +206,7 @@
 
     <stack hidden="true" id="note_template" flex="1">
         <groupbox flex="1" style="background-color: black;"/>
-        <groupbox flex="1" style="background-color: #FFDE00; -moz-border-radius-topright: 35px;" >
+        <groupbox flex="1" style="background-color: #FFDE00; border-top-right-radius: 35px;" >
             <hbox>
                 <description name="title" class="copyable" style="font-weight: bold"/>
                 <spacer flex="1"/>

diff --git a/Open-ILS/xul/staff_client/server/circ/alternate_copy_summary.xul b/Open-ILS/xul/staff_client/server/circ/alternate_copy_summary.xul
index a06ea95..aaf6b56 100644 (file)
--- a/Open-ILS/xul/staff_client/server/circ/alternate_copy_summary.xul
+++ b/Open-ILS/xul/staff_client/server/circ/alternate_copy_summary.xul
@@ -287,14 +287,14 @@
                     </grid>
                 </tabpanel>
                 <tabpanel orient="vertical"><!-- Hold/Transit -->
-                    <groupbox flex="1" id="holds" style="overflow: none; min-height: 80;" oils_persist="height">
+                    <groupbox flex="1" id="holds" style="overflow: hidden; min-height: 120px;" oils_persist="height">
                         <caption id="hold_caption" label="&staff.circ.copy_details.hold_caption;"/>
                         <label id="hold_patron_name" class="patronNameLarge click_link"/>
                         <tree id="hold" flex="1" enableColumnDrag="true"/>
                         <spacer FIXME="label and tree get swapped without this"/>
                     </groupbox>
                     <splitter id="splitter" oils_persist="state hidden" oils_persist_peers="holds transits"><grippy/></splitter>
-                    <groupbox flex="1" id="transits" style="overflow: none; min-height: 80;" oils_persist="height">
+                    <groupbox flex="1" id="transits" style="overflow: hidden; min-height: 80px;" oils_persist="height">
                         <caption id="transit_caption" label="&staff.circ.copy_details.transit_caption;"/>
                         <tree id="transit" flex="1" enableColumnDrag="true"/>
                     </groupbox>

diff --git a/Open-ILS/xul/staff_client/server/patron/hold_details.xul b/Open-ILS/xul/staff_client/server/patron/hold_details.xul
index 245a061..7e37fed 100644 (file)
--- a/Open-ILS/xul/staff_client/server/patron/hold_details.xul
+++ b/Open-ILS/xul/staff_client/server/patron/hold_details.xul
@@ -36,7 +36,7 @@
 
     <stack hidden="true" id="notification_template" flex="1">
         <groupbox flex="1" style="background-color: black;"/>
-        <groupbox flex="1" style="background-color: #FFDE00; -moz-border-radius-topright: 35px;" >
+        <groupbox flex="1" style="background-color: #FFDE00; border-top-right-radius: 35px;" >
             <hbox>
                 <description name="method" label="&staff.patron.hold_notices.method.label;" style="font-weight: bold"/>
                 <spacer flex="1"/>
@@ -48,7 +48,7 @@
 
     <stack hidden="true" id="note_template" flex="1">
         <groupbox flex="1" style="background-color: black;"/>
-        <groupbox flex="1" style="background-color: #FFDE00; -moz-border-radius-topright: 35px;" >
+        <groupbox flex="1" style="background-color: #FFDE00; border-top-right-radius: 35px;" >
             <hbox>
                 <description name="title" style="font-weight: bold"/>
                 <spacer flex="1"/>

diff --git a/Open-ILS/xul/staff_client/server/patron/info_notes.xul b/Open-ILS/xul/staff_client/server/patron/info_notes.xul
index d0be818..d4252f0 100644 (file)
--- a/Open-ILS/xul/staff_client/server/patron/info_notes.xul
+++ b/Open-ILS/xul/staff_client/server/patron/info_notes.xul
@@ -248,7 +248,7 @@
 
     <stack hidden="true" id="note_template" flex="1" minheight="50px">
         <groupbox flex="1" style="background-color: black;"/>
-        <groupbox flex="1" style="background-color: #FFDE00; -moz-border-radius-topright: 35px;" >
+        <groupbox flex="1" style="background-color: #FFDE00; border-top-right-radius: 35px;" >
             <hbox>
                 <description name="title" class="copyable" style="font-weight: bold"/>
                 <spacer flex="1"/>

diff --git a/Open-ILS/xul/staff_client/server/patron/info_stat_cats.xul b/Open-ILS/xul/staff_client/server/patron/info_stat_cats.xul
index 400aa67..823b7c8 100644 (file)
--- a/Open-ILS/xul/staff_client/server/patron/info_stat_cats.xul
+++ b/Open-ILS/xul/staff_client/server/patron/info_stat_cats.xul
@@ -181,7 +181,7 @@
 
     <stack hidden="true" id="actsc_template" flex="1">
         <groupbox flex="1" style="background-color: black;"/>
-        <groupbox flex="1" style="background-color: #99CC66; -moz-border-radius-topright: 35px;" >
+        <groupbox flex="1" style="background-color: #99CC66; border-top-right-radius: 35px;" >
             <hbox>
                 <description name="name" style="font-weight: bold"/>
                 <spacer flex="1"/>

diff --git a/Open-ILS/xul/staff_client/server/patron/info_surveys.xul b/Open-ILS/xul/staff_client/server/patron/info_surveys.xul
index c0fb29b..d9c33db 100644 (file)
--- a/Open-ILS/xul/staff_client/server/patron/info_surveys.xul
+++ b/Open-ILS/xul/staff_client/server/patron/info_surveys.xul
@@ -169,7 +169,7 @@
     
     <stack hidden="true" id="asv_template" flex="1">
         <groupbox flex="1" style="background-color: black;"/>
-        <groupbox flex="1" style="background-color: #CC9966; -moz-border-radius-topright: 35px;" >
+        <groupbox flex="1" style="background-color: #CC9966; border-top-right-radius: 35px;" >
             <hbox>
                 <label value="&staff.patron.info_surveys.survey_number.value;" style="font-weight: bold"/>
                 <label name="id" style="font-weight: bold"/>

diff --git a/Open-ILS/xul/staff_client/server/serial/notes.xul b/Open-ILS/xul/staff_client/server/serial/notes.xul
index 7e12c62..8e8e673 100644 (file)
--- a/Open-ILS/xul/staff_client/server/serial/notes.xul
+++ b/Open-ILS/xul/staff_client/server/serial/notes.xul
@@ -335,7 +335,7 @@
 
        <stack hidden="true" id="note_template" flex="1">
                <vbox flex="1" style="background-color: black; margin:3px"/>
-               <vbox flex="1" style="background-color: #FFDE00; -moz-border-radius-topright: 35px; border: 2px groove ThreeDFace; margin:3px;" >
+               <vbox flex="1" style="background-color: #FFDE00; border-top-right-radius: 35px; border: 2px groove ThreeDFace; margin:3px;" >
                        <hbox align="start">
                                <description name="title" style="font-weight: bold"/>
                                <spacer flex="1"/>

diff --git a/Open-ILS/xul/staff_client/server/serial/sitem_editor.xul b/Open-ILS/xul/staff_client/server/serial/sitem_editor.xul
index 53000b1..126df3e 100644 (file)
--- a/Open-ILS/xul/staff_client/server/serial/sitem_editor.xul
+++ b/Open-ILS/xul/staff_client/server/serial/sitem_editor.xul
@@ -76,7 +76,7 @@
                        </vbox>
                        <splitter id="splitter2" oils_persist="state hidden" oils_persist_peers="after_slitter1 after_splitter2"><grippy /></splitter>
                        <vbox flex="1" id="after_splitter2" oils_persist="width">
-                               <button style="font-weight: bold; font-size: normal" label="&staff.serial.sitem_editor.item_dates.btn;" accesskey="&staff.serial.sitem_editor.item_dates.accesskey;" oncommand="document.getElementById('sitem_editor_right_pane').firstChild.firstChild.focus();"/>
+                               <button style="font-weight: bold; font-size: medium" label="&staff.serial.sitem_editor.item_dates.btn;" accesskey="&staff.serial.sitem_editor.item_dates.accesskey;" oncommand="document.getElementById('sitem_editor_right_pane').firstChild.firstChild.focus();"/>
                                <vbox id="sitem_editor_right_pane" flex="1"/>
                        </vbox>
                </hbox>

diff --git a/Open-ILS/xul/staff_client/server/skin/global.css b/Open-ILS/xul/staff_client/server/skin/global.css
index f8a6ad1..25412f5 100644 (file)
--- a/Open-ILS/xul/staff_client/server/skin/global.css
+++ b/Open-ILS/xul/staff_client/server/skin/global.css
@@ -92,8 +92,8 @@ treechildren::-moz-tree-cell-text(selected,focus) {
 
 button.sym {width:2em; min-width:1em; }
 
-.outline_me { -moz-outline: solid; }
-.clipboard_outline_me { -moz-outline: dotted thin gray; }
+.outline_me { outline: solid; }
+.clipboard_outline_me { outline: dotted thin gray; }
 
 .click_link { text-decoration: underline; color: blue; -moz-user-focus: normal; cursor: pointer; }
 
@@ -124,8 +124,8 @@ iframe { background: #CDCED3 url("chrome://browser/skin/icons/box-background.png
 .my_bg { background: #CDCED3 url("chrome://browser/skin/icons/box-background.png") repeat-x bottom !important; }
 */
 
-.postit_hb { -moz-border-radius: 30px; background-color: black; }
-.postit_gb { -moz-border-radius: 30px; background-color: yellow; }
+.postit_hb { border-radius: 30px; background-color: black; }
+.postit_gb { border-radius: 30px; background-color: yellow; }
 
 .success_text { color: white; background-color: green; }
 .failure_text { color: white; background-color: red; }