LP#1361801: Add required fields to serial issuance form
authorRemington Steed <rjs7@calvin.edu>
Fri, 29 Aug 2014 18:45:50 +0000 (14:45 -0400)
committerBen Shum <bshum@biblio.org>
Thu, 18 Sep 2014 21:03:48 +0000 (17:03 -0400)
This commit prevents issuances from being created without a date_published
or holding_code. This has two benefits:

  1. Prevents uncaught exceptions related to submitting null values for
     either of those fields.
  2. Requiring date_published prevents an ugly error when trying to
     predict new issuances from an issuance without a date_published.

This commit does NOT provide any feedback to the user about which fields
are required. That would require further investigation into the Dojo/Dijit
objects being used for the edit form fields.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Jennifer Pringle <jpringle@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
Open-ILS/src/templates/serial/subscription/issuance.tt2

index aaa0ee8..a90e5b0 100644 (file)
@@ -28,6 +28,7 @@
         fmClass="siss"
         query="{id: '*'}"
         editOnEnter="true"
+        requiredFields="['date_published','holding_code']"
         showPaginator="true">
         <thead>
             <tr>