LP 1768715: Fix pingest.pl bug discovered by Dan Scott of Laurentian U.
authorJason Stephenson <jason@sigio.com>
Sat, 2 Jun 2018 23:18:40 +0000 (19:18 -0400)
committerBill Erickson <berickxx@gmail.com>
Thu, 23 Aug 2018 16:27:55 +0000 (12:27 -0400)
Reingest was not happening if all ingests were skipped, except for the
display field reingest.  This came down to a matter of two conditional
statements not including checks for the $skip_display variable being
true.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Open-ILS/src/support-scripts/pingest.pl

index fac993c..2ddaac5 100755 (executable)
@@ -202,7 +202,7 @@ while ($count < $lists) {
     if (scalar(@lol) && scalar(@running) < $max_child && !$duration_expired) {
         # Reuse $records for the lulz.
         $records = shift(@lol);
-        if ($skip_search && $skip_facets && $skip_attrs) {
+        if ($skip_search && $skip_facets && $skip_attrs && $skip_display) {
             $count++;
         } else {
             reingest($records);
@@ -271,7 +271,7 @@ sub reingest {
                                $db_user, $db_password);
         reingest_attributes($dbh, $list) unless ($skip_attrs);
         reingest_field_entries($dbh, $list)
-            unless ($skip_facets && $skip_search);
+            unless ($skip_facets && $skip_search && $skip_display);
         $dbh->disconnect();
         exit(0);
     }