LP#1413592: Avoid generating fines in "consider zero balance closed" mode

We will now also disable the behavior triggered by the "Lost Checkin
Generates New Overdues" org setting when the new "Do not change fines/fees
on zero-balance LOST transaction" org setting is enabled.  This is to follow
the new rule that the new setting creates: a zero-balance LOST transaction is
considered handled, and should not be changed by the system.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
index 6cfe056..b9737b8 100644 (file)
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
@@ -3600,6 +3600,7 @@ sub checkin_handle_lost_or_longoverdue {
         # marked as long-overdue before it was done being regular-overdue
         if (!$args{is_longoverdue}) {
             $self->generate_lost_overdue(1) if 
+                !$dont_change and
                 $U->ou_ancestor_setting_value($circ_lib, 
                     OILS_SETTING_GENERATE_OVERDUE_ON_LOST_RETURN, 
                     $self->editor);