LP#1810296: Fix selfcheck patron password setting check

Previously, the selfcheck ignored this setting if it was
set to "False", since the setting value is stored as text
and the truth test always succeeded.  Instead, explicitly
check that the setting is "True".

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

diff --git a/Open-ILS/web/js/ui/default/circ/selfcheck/selfcheck.js b/Open-ILS/web/js/ui/default/circ/selfcheck/selfcheck.js
index a17b8cd..f3d0b93 100644 (file)
--- a/Open-ILS/web/js/ui/default/circ/selfcheck/selfcheck.js
+++ b/Open-ILS/web/js/ui/default/circ/selfcheck/selfcheck.js
@@ -349,7 +349,7 @@ SelfCheckManager.prototype.drawLoginPage = function() {
     var bcHandler = function(barcode_or_usrname) {
         // handle patron barcode/usrname entry
 
-        if(self.orgSettings[SET_PATRON_PASSWORD_REQUIRED]) {
+        if(self.orgSettings[SET_PATRON_PASSWORD_REQUIRED] == 'True') {
             
             // password is required.  wire up the scan box to read it
             self.updateScanBox({
@@ -391,7 +391,7 @@ SelfCheckManager.prototype.loginPatron = function(barcode_or_usrname, passwd) {
         usrname = barcode_or_usrname;
     }
 
-    if(this.orgSettings[SET_PATRON_PASSWORD_REQUIRED]) {
+    if(this.orgSettings[SET_PATRON_PASSWORD_REQUIRED] == 'True') {
         
         if(!passwd) {
             // would only happen in dev/debug mode when using the patron= param