LP#1668682 Checkout holds fullfill ignores expire time
authorBill Erickson <berickxx@gmail.com>
Tue, 28 Feb 2017 16:33:25 +0000 (11:33 -0500)
committerKathy Lussier <klussier@masslnc.org>
Tue, 14 Mar 2017 13:17:00 +0000 (09:17 -0400)
Checking out a hold-captured item for a hold whose expire time is in the
past, but has not yet been canceled by the hold targeter, now marks the
hold as fulfilled.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm

index 7dd3611..74e425b 100644 (file)
@@ -1559,11 +1559,7 @@ sub handle_checkout_holds {
     my $hold = $e->search_action_hold_request({   
         current_copy        => $copy->id , 
         cancel_time         => undef, 
-        fulfillment_time    => undef,
-        '-or' => [
-            {expire_time => undef},
-            {expire_time => {'>' => 'now'}}
-        ]
+        fulfillment_time    => undef
     })->[0];
 
     if($hold and $hold->usr != $patron->id) {