LP#1695029-Webstaff Fix Patron Registration page never loading
authorCesar Velez <cesar.velez@equinoxinitiative.org>
Tue, 27 Jun 2017 19:06:48 +0000 (15:06 -0400)
committerJason Etheridge <jason@EquinoxInitiative.org>
Thu, 31 Aug 2017 03:56:59 +0000 (23:56 -0400)
It looks like there was a variable mistype causing the page
to not load, but the setting that the lp bug mentions wasn't being
properly bound and needed to be wrapped to a boolean.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js

index 6d9ddc8..0ec59df 100644 (file)
@@ -516,8 +516,8 @@ angular.module('egCoreMod')
                 // apply default user setting values
                 angular.forEach(setting_types, function(stype, index) {
                     if (stype.reg_default() != undefined) {
-                        service.user_settings[setting.name()] = 
-                            setting.reg_default();
+                        service.user_settings[stype.name()] =
+                            Boolean(stype.reg_default());
                     }
                 });
             }