LP#1262722 Fix DB supersedes/deprecates pgtap test
authorBill Erickson <berick@esilibrary.com>
Wed, 19 Feb 2014 15:22:37 +0000 (10:22 -0500)
committerJeff Godin <jgodin@tadl.org>
Wed, 19 Feb 2014 16:27:46 +0000 (11:27 -0500)
Sort multi-value arrays before passing them off to pgtap for test
comparison. Otherwise, pgtap tests may fail with:

Failed test 5
        have: {AAAC,AAAB}
        want: {AAAB,AAAC}

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jeff Godin <jgodin@tadl.org>
Open-ILS/src/sql/Pg/t/db_patch_dep_checks.pg

index 57c5085..19ce243 100644 (file)
@@ -29,7 +29,14 @@ SELECT is(
 
 -- AAAF deprecates AAAB, AAAC
 SELECT is(
-    (SELECT ARRAY_AGG(patch) FROM evergreen.upgrade_list_applied_deprecates('AAAF')),
+    (   SELECT ARRAY_AGG(patch)
+        FROM (
+            -- sort the patches to match the expected output
+            SELECT patch
+            FROM evergreen.upgrade_list_applied_deprecates('AAAF')
+            ORDER BY patch
+        ) AS patch
+    ),
     '{AAAB,AAAC}'
 );