acq - prevent create/add to purchase order from stealing lineitems

that is, lineitem from other POs

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Order.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Order.pm
index 9572552..60e30b2 100644 (file)
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Order.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Order.pm
@@ -1781,6 +1781,14 @@ sub create_purchase_order_api {
                 {flesh => 1, flesh_fields => {jub => ['attributes']}}
             ]) or return $e->die_event;
 
+            return $e->die_event(
+                new OpenILS::Event(
+                    "BAD_PARAMS", payload => $li,
+                        note => "acq.lineitem #" . $li->id .
+                        ": purchase_order #" . $li->purchase_order
+                )
+            ) if $li->purchase_order;
+
             $li->provider($po->provider);
             $li->purchase_order($po->id);
             $li->state('pending-order');
@@ -3496,7 +3504,8 @@ sub add_li_to_po {
     }
 
     foreach my $li (@$lis) {
-        unless ($li->state =~ /new|order-ready|pending-order/) {
+        if ($li->state !~ /new|order-ready|pending-order/ or
+            $li->purchase_order) {
             $e->rollback;
             return {success => 0, li => $li, error => 'bad-li-state'};
         }