fix a Down action bug in Configure Toolbars

where the list selection index could be set to an invalid value, which could
cause errors for actions acting upon that index

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

diff --git a/Open-ILS/xul/staff_client/server/admin/toolbar.js b/Open-ILS/xul/staff_client/server/admin/toolbar.js
index 8e899be..8a0e17a 100644 (file)
--- a/Open-ILS/xul/staff_client/server/admin/toolbar.js
+++ b/Open-ILS/xul/staff_client/server/admin/toolbar.js
@@ -303,6 +303,7 @@ function populate_list2_list3(list3_idx) {
 
         if (list3_idx) {
             if (list3_idx < 0) { list3_idx = 0; }
+            if (list3_idx >= g.list3.node.view.rowCount) { list3_idx = g.list3.node.view.rowCount - 1; }
             g.list3.node.view.selection.select(list3_idx);
         }