LP#1721139: apply proper date format in certain places
authorGalen Charlton <gmc@equinoxinitiative.org>
Tue, 11 Sep 2018 18:58:29 +0000 (14:58 -0400)
committerGalen Charlton <gmc@equinoxinitiative.org>
Fri, 5 Oct 2018 21:11:41 +0000 (17:11 -0400)
This patch ensures that the correct date format is used
to display dates in certain contexts in the web staff
client:

- patron bucket summary
- record bucket summary
- patron bucket 'View batch edits'

This has the side effect of fixing a problem where the batch
edit timestamps were not wrapped correctly in Firefox.

To test
-------
1. Using user buckets, make some batch changes on some patrons and roll
   back some of those changes.
2. Using Firefox, click on the 'View Batch Edits' button.
3. Note that the times dispayed are formatted as raw
   database timestamps
4. Note that the summary for the user bucket displays the
   create time as a raw database timestamp.
5. Navigate to a record bucket and note that its create
   time is displayed as a raw timestamp as well.
3. Apply patch.
4. Repeat steps 2-5; this time, the times should be displayed
   using the correct date and time format.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Open-ILS/src/templates/staff/cat/bucket/share/t_bucket_info.tt2
Open-ILS/src/templates/staff/circ/patron/bucket/t_bucket_info.tt2
Open-ILS/src/templates/staff/circ/patron/bucket/t_changesets.tt2

index 9862c33..333f8ee 100644 (file)
@@ -6,7 +6,7 @@
       when="{'one': '[% l("1 item") %]', 'other': '[% l("{} items") %]'}">
     </ng-pluralize>
   </span>
-  <span> / [% l('Created {{bucket().create_time() | date}}') %]</span>
+  <span> / [% l('Created {{bucket().create_time() | date:egDateAndTimeFormat}}') %]</span>
   <span ng-show="bucket()._owner_name"> / 
     {{bucket()._owner_name}} 
     <a target="_self" href="./circ/patron/{{bucket().owner()}}/checkout">
index 6245f95..ee05b48 100644 (file)
@@ -6,7 +6,7 @@
       when="{'one': '[% l("1 item") %]', 'other': '[% l("{} items") %]'}">
     </ng-pluralize>
   </span> 
-  <span> / [% l('Created {{bucket().create_time() | date}}') %]</span>
+  <span> / [% l('Created {{bucket().create_time() | date:egDateAndTimeFormat}}') %]</span>
   <span ng-show="bucket().description()"> / {{bucket().description()}}</span>
 </div>
 
index dc98390..dce5481 100644 (file)
           {{g.name()}}
         </div>
         <div class="col-md-3">
-          {{g.complete_time() | date}}
+          {{g.complete_time() | date:egDateAndTimeFormat}}
         </div>
         <div class="col-md-3">
-          {{g.rollback_time() | date}}
+          {{g.rollback_time() | date:egDateAndTimeFormat}}
         </div>
         <div class="col-md-2">
           <button class="btn btn-primary"