better view membership test

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

diff --git a/Open-ILS/src/sql/Pg/make-pgtap-tests.pl b/Open-ILS/src/sql/Pg/make-pgtap-tests.pl
index cd1ef86..a6ec784 100755 (executable)
--- a/Open-ILS/src/sql/Pg/make-pgtap-tests.pl
+++ b/Open-ILS/src/sql/Pg/make-pgtap-tests.pl
@@ -217,12 +217,22 @@ sub handle_views {
     my $callback = shift;
 
     my @views = fetch_views($schema);
+    if (scalar @views == 0) {
+        return;
+    }
+
+    print "SELECT views_are(\n";
+    print "\t" . $dbh->quote($schema) . ",\n";
+    print "\tARRAY[\n\t\t";
+    print join(
+        ",\n\t\t",
+        map { $dbh->quote($_) } @views
+    );
+    print "\n\t],\t" . $dbh->quote("Found expected views for schema $schema");
+    print "\n);\n";
+
     foreach my $view ( @views ) {
         print "\n-- -- view " . $dbh->quote("$schema.$view") . "\n\n";
-        print "SELECT has_view(\n";
-        print "\t" . $dbh->quote($schema) . ",\n";
-        print "\t" . $dbh->quote($view) . ",\n";
-        print "\t" . $dbh->quote("Has view $schema.$view") . "\n);\n";
         $callback->($schema,$view) if $callback;
     }
 }