Avoiding memory leaks in string opperations

 - patch provided by Scott McKellar
 - http://list.georgialibraries.org/pipermail/open-ils-dev/2007-April/000724.html

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_0@7181 dcc99617-32d9-48b4-a31d-7c20da2025e4

diff --git a/OpenSRF/src/utils/utils.c b/OpenSRF/src/utils/utils.c
index a226cab..bdeaa96 100644 (file)
--- a/OpenSRF/src/utils/utils.c
+++ b/OpenSRF/src/utils/utils.c
@@ -1,7 +1,5 @@
 /*
 Copyright (C) 2005  Georgia Public Library Service 
-Bill Erickson <highfalutin@gmail.com>
-Mike Rylander <mrylander@gmail.com>
 
 This program is free software; you can redistribute it and/or
 modify it under the terms of the GNU General Public License
@@ -290,6 +288,7 @@ char* uescape( const char* string, int size, int full_escape ) {
                                buffer_fadd(buf, "\\u%04x", c);
 
                        } else {
+                               buffer_free(buf);
                                return NULL;
                        }
 
@@ -370,13 +369,14 @@ int daemonize() {
        }
 }
 
+
+/* Return 1 if the string represents an integer,  */
+/* as recognized by strtol(); Otherwise return 0. */
+
 int stringisnum(char* s) {
-       char* w = (char*) malloc(strlen(s) * sizeof(char*));
-       bzero(w, strlen(s));
+       char* w;
        strtol(s, &w, 10);
-       if(strlen(w) > 0)  
-               return 0;
-       return 1;
+       return *w ? 0 : 1;
 }