Making the user profile selector disabled rather than readonly

in the case of a user editing their own account.  This prevents
a nasty bug whereby Dojo widgets with the readOnly flag set
become labels and therefore do not correctly hold a 'value'
like a normal form widget.  See LP#806625 for details.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>

diff --git a/Open-ILS/web/js/ui/default/actor/user/register.js b/Open-ILS/web/js/ui/default/actor/user/register.js
index 30359fe..0a8d886 100644 (file)
--- a/Open-ILS/web/js/ui/default/actor/user/register.js
+++ b/Open-ILS/web/js/ui/default/actor/user/register.js
@@ -818,8 +818,6 @@ function fleshFMRow(row, fmcls, args) {
         // not overwritten when the profile groups arrive and update
         wargs.forceSync = true;
         wargs.disableQuery = {usergroup : 'f'};
-        if(!patron.isnew() && !checkGrpAppPerm(patron.profile()))
-            wargs.readOnly = true;
     } else {
         wargs.forceSync = false;
     }
@@ -832,7 +830,12 @@ function fleshFMRow(row, fmcls, args) {
     var widget = new openils.widget.AutoFieldWidget(wargs);
     widget.build(
         function(w, ww) {
-            if(fmfield == 'profile') { trimGrpTree(ww); }
+            if(fmfield == 'profile') {
+                trimGrpTree(ww);
+                if(!patron.isnew() && !checkGrpAppPerm(patron.profile())){
+                    w.attr('disabled', true);
+                }
+            }
         }
     );