LP#1584801: fix tagging of previous circs in metarecord search results
authorGalen Charlton <gmc@esilibrary.com>
Mon, 23 May 2016 14:29:09 +0000 (10:29 -0400)
committerKathy Lussier <klussier@masslnc.org>
Tue, 24 May 2016 17:52:39 +0000 (13:52 -0400)
This patch fixes a bug where previously-checked-out items were not
indicated as such in search results when doing a metarecord search.

To test:

[1] Ensure that the opac.search.tag_circulated_items library setting
    is enabled and that you are testing with a user that has opted-in
    to retaining circ history.
[2] Make a couple loans to that user.
[3] Log into the public catalog using that user.
[4] Perform a catalog search, choosing search terms such that
    the previously-loaned items appear in results.
[5] Verify that "I have checked this item out before" is displayed
    on the relevant hits.
[6] Click the "Group Formats and Editions" checkbox; note that
    after the page refreshes, previously-borrowed hits are /not/
    tagged.
[7] Apply the patch and restart the open-ils.search service.
[8] Repeat step 6; verify that this time previously-borrowed hits
    are tagged.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Biblio.pm

index 708dc90..a337619 100644 (file)
@@ -1472,8 +1472,8 @@ sub tag_circulated_records {
 
     if ($metabib) {
         $query = {
-            select   => { mmsm => [{ column => 'metarecord', alias => 'tagme' }] },
-            from     => 'mmsm',
+            select   => { mmrsm => [{ column => 'metarecord', alias => 'tagme' }] },
+            from     => 'mmrsm',
             where    => { source => { in => $query } },
             distinct => 1
         };