LP1904036 lint and repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

diff --git a/Open-ILS/src/eg2/src/app/staff/circ/checkin/checkin.component.html b/Open-ILS/src/eg2/src/app/staff/circ/checkin/checkin.component.html
index 0ad28c6..91a64b3 100644 (file)
--- a/Open-ILS/src/eg2/src/app/staff/circ/checkin/checkin.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/circ/checkin/checkin.component.html
@@ -12,8 +12,7 @@
           <span class="input-group-text" i18n>Barcode</span>
         </div>
         <input type="text" class="form-control" id="barcode-input"
-          placeholder="Barcode..." i18n-placeholder
-          [(ngModel)]="barcode" [disabled]="checkinNoncat != null"
+          placeholder="Barcode..." i18n-placeholder [(ngModel)]="barcode"
           i18n-aria-label aria-label="Barcode Input" (keydown.enter)="checkin()" />
         <div class="input-group-append">
           <button class="btn btn-outline-dark" (keydown.enter)="checkin()" 
@@ -24,8 +23,8 @@
     <div class="flex-1"></div>
     <div>
       <span class="mr-2" i18n>Effective Date:</span>
-      <eg-date-select [initialIso]="effectiveDate" 
-        (onChangeAsIso)="setEffectiveDate($event)"></eg-date-select>
+      <eg-date-select [initialIso]="backdate" 
+        (onChangeAsIso)="backdate = $event"></eg-date-select>
     </div>
   </div>
 </div>

diff --git a/Open-ILS/src/eg2/src/app/staff/circ/checkin/checkin.component.ts b/Open-ILS/src/eg2/src/app/staff/circ/checkin/checkin.component.ts
index 52543b5..f07d5ed 100644 (file)
--- a/Open-ILS/src/eg2/src/app/staff/circ/checkin/checkin.component.ts
+++ b/Open-ILS/src/eg2/src/app/staff/circ/checkin/checkin.component.ts
@@ -16,6 +16,7 @@ import {BarcodeSelectComponent
 
 interface CheckinGridEntry extends CheckinResult {
     // May need to extend...
+    foo?: number; // Empty interfaces are not allowed.
 }
 
 @Component({

diff --git a/Open-ILS/src/eg2/src/app/staff/circ/patron/perms.component.ts b/Open-ILS/src/eg2/src/app/staff/circ/patron/perms.component.ts
index 0e8eec6..1c2045f 100644 (file)
--- a/Open-ILS/src/eg2/src/app/staff/circ/patron/perms.component.ts
+++ b/Open-ILS/src/eg2/src/app/staff/circ/patron/perms.component.ts
@@ -22,7 +22,7 @@ export class PatronPermsComponent implements OnInit, AfterViewInit {
 
     @Input() patronId: number;
 
-    myPermMaps:  {[permId: number]: IdlObject} = {}
+    myPermMaps:  {[permId: number]: IdlObject} = {};
     userPermMaps: {[permId: number]: IdlObject} = {};
     userWorkOuMaps: {[orgId: number]: IdlObject} = {};
 
@@ -79,7 +79,7 @@ export class PatronPermsComponent implements OnInit, AfterViewInit {
 
         .then(_ => {
             this.progress.increment();
-            return this.perms.hasWorkPermAt(['ASSIGN_WORK_ORG_UNIT'], true)
+            return this.perms.hasWorkPermAt(['ASSIGN_WORK_ORG_UNIT'], true);
         })
 
         .then(perms => {
@@ -233,7 +233,7 @@ export class PatronPermsComponent implements OnInit, AfterViewInit {
                 'open-ils.actor',
                 'open-ils.actor.user.permissions.update',
                 this.auth.token(), permMaps
-            )
+            );
         }))
         .pipe(concatMap(_ => this.reload()))
         .pipe(finalize(() => this.loading = false)).subscribe();

diff --git a/Open-ILS/src/eg2/src/app/staff/share/circ/circ.service.ts b/Open-ILS/src/eg2/src/app/staff/share/circ/circ.service.ts
index ae7f817..eb51abc 100644 (file)
--- a/Open-ILS/src/eg2/src/app/staff/share/circ/circ.service.ts
+++ b/Open-ILS/src/eg2/src/app/staff/share/circ/circ.service.ts
@@ -411,10 +411,10 @@ export class CircService {
         // which is OK.
         if (!payload) { return Promise.resolve(result); }
 
-        result.circ = payload.circ,
-        result.copy = payload.copy,
-        result.record = payload.record,
-        result.nonCatCirc = payload.noncat_circ
+        result.circ = payload.circ;
+        result.copy = payload.copy;
+        result.record = payload.record;
+        result.nonCatCirc = payload.noncat_circ;
 
         return this.fleshCommonData(result);
     }
@@ -467,7 +467,7 @@ export class CircService {
     }
 
     exitAlert(context: any): Promise<any> {
-        let key = 'staff.circ.events.' + context.textcode;
+        const key = 'staff.circ.events.' + context.textcode;
         return this.strings.interpolate(key, context)
         .then(str => {
             this.components.circFailedDialog.dialogBody = str;
@@ -491,15 +491,15 @@ export class CircService {
                     // we have the specifics on the copy, go ahead and
                     // copy them into the params we use for the follow
                     // up checkout.
-                    result.params.copy_barcode = result.copy.barcode()
-                    result.params.copy_id = result.copy.id()
+                    result.params.copy_barcode = result.copy.barcode();
+                    result.params.copy_id = result.copy.id();
                     return this.checkout(result.params);
                 });
 
             } else {
                 return result;
             }
-        })
+        });
     }
 
     // Ask the user if we should resolve the circulation and check
@@ -723,8 +723,6 @@ export class CircService {
         const circ = result.circ;
         const parent_circ = result.parent_circ;
 
-        let promise = Promise.resolve();
-
         if (transit) {
             if (typeof transit.dest() !== 'object') {
                 transit.dest(this.org.get(transit.dest()));

diff --git a/Open-ILS/src/eg2/src/app/staff/share/circ/route-dialog.component.ts b/Open-ILS/src/eg2/src/app/staff/share/circ/route-dialog.component.ts
index aa90d3f..4f04892 100644 (file)
--- a/Open-ILS/src/eg2/src/app/staff/share/circ/route-dialog.component.ts
+++ b/Open-ILS/src/eg2/src/app/staff/share/circ/route-dialog.component.ts
@@ -80,7 +80,7 @@ export class RouteDialogComponent extends DialogComponent {
             })
             .then(addr => {
                 this.checkin.destAddress = addr;
-                return this.org.settings('lib.courier_code', this.checkin.destOrg.id())
+                return this.org.settings('lib.courier_code', this.checkin.destOrg.id());
             })
 
             .then(sets => this.checkin.destCourierCode = sets['lib.courier_code']);