Replace idiomatic perl checksum code, which seems to fail on

strings with diacriticals in them, with an explicit sum of the
ordinal values of the characters in the string, which seems to cope.

diff --git a/Sip/Checksum.pm b/Sip/Checksum.pm
index dd5776b..07bcd9f 100644 (file)
--- a/Sip/Checksum.pm
+++ b/Sip/Checksum.pm
@@ -1,4 +1,3 @@
-\r
 package Sip::Checksum;\r
 \r
 use Exporter;\r
@@ -10,8 +9,15 @@ our @EXPORT_OK = qw(checksum verify_cksum);
 \r
 sub checksum {\r
     my $pkt = shift;\r
+    my $cksum;\r
 \r
-    return (-unpack("%16C*", $pkt)) & 0xFFFF;\r
+    $cksum = 0;\r
+    foreach my $chr (map(ord, split(//, $pkt))) {\r
+       $cksum += $chr;\r
+    }\r
+    $cksum = (-$cksum) & 0xFFFF;\r
+\r
+    return $cksum;\r
 }\r
 \r
 sub verify_cksum {\r
@@ -52,3 +58,5 @@ while (<>) {
     chomp;\r
     test($_);\r
 }\r
+\r
+1;\r