Add test for attempting to renew item that has outstanding

holds.

diff --git a/t/09renew.t b/t/09renew.t
index ea2cb04..0850dd3 100644 (file)
--- a/t/09renew.t
+++ b/t/09renew.t
@@ -10,43 +10,58 @@ use Sip::Constants qw(:all);
 use SIPtest qw($datepat $textpat);
 
 my $checkout_template = {
-    id => 'Renew: prep: check out item',
-    msg => '11YN20060329    203000                  AOUWOLS|AAdjfiander|AB1565921879|AC|',
-    pat => qr/^121NNY$datepat/,
-    fields => [],
-};
+                        id => 'Renew: prep: check out item',
+                        msg => '11YN20060329    203000                  AOUWOLS|AAdjfiander|AB1565921879|AC|',
+                        pat => qr/^121NNY$datepat/,
+                        fields => [],
+                       };
 
 my $checkin_template = {
-    id => 'Renew: prep: check in item',
-    msg => '09N20060102    08423620060113    084235APUnder the bed|AOUWOLS|AB1565921879|ACterminal password|',
-    pat => qr/^10YYNN$datepat/,
-    fields => [],
-};
+                       id => 'Renew: prep: check in item',
+                       msg => '09N20060102    08423620060113    084235APUnder the bed|AOUWOLS|AB1565921879|ACterminal password|',
+                       pat => qr/^10YYNN$datepat/,
+                       fields => [],
+                      };
+
+my $hold_template = {
+                    id => 'Renew: prep: place hold on item',
+                    msg =>'15+20060415    110158BW20060815    110158|BSTaylor|BY2|AOUWOLS|AAmiker|AB1565921879|',
+                    pat => qr/^161N$datepat/,
+                    fields => [],
+                   };
+
+my $cancel_hold_template = {
+                    id => 'Renew: cleanup: cancel hold on item',
+                    msg =>'15-20060415    110158BW20060815    110158|BSTaylor|BY2|AOUWOLS|AAmiker|AB1565921879|',
+                    pat => qr/^161[NY]$datepat/,
+                    fields => [],
+                   };
+
 
 my $renew_test_template = {
-    id => 'Renew: item id checked out to patron, renewal permitted, no 3rd party, no fees',
-    msg => '29NN20060102    084236                  AOUWOLS|AAdjfiander|AB1565921879|',
-    pat => qr/^301YNN$datepat/,
-    fields => [
-              $SIPtest::field_specs{(FID_INST_ID)},
-              $SIPtest::field_specs{(FID_SCREEN_MSG)},
-              $SIPtest::field_specs{(FID_PRINT_LINE)},
-              { field    => FID_PATRON_ID,
-                pat      => qr/^djfiander$/,
-                required => 1, },
-              { field    => FID_ITEM_ID,
-                pat      => qr/^1565921879$/,
-                required => 1, },
-              { field    => FID_TITLE_ID,
-                pat      => qr/^Perl 5 desktop reference$/,
-                required => 1, },
-              { field    => FID_DUE_DATE,
-                pat      => qr/^$datepat$/,
-                required => 1, },
-              { field    => FID_SECURITY_INHIBIT,
-                pat      => qr/^[YN]$/,
-                required => 0, },
-              ],};
+                          id => 'Renew: item id checked out to patron, renewal permitted, no 3rd party, no fees',
+                          msg => '29NN20060102    084236                  AOUWOLS|AAdjfiander|AB1565921879|',
+                          pat => qr/^301YNN$datepat/,
+                          fields => [
+                                     $SIPtest::field_specs{(FID_INST_ID)},
+                                     $SIPtest::field_specs{(FID_SCREEN_MSG)},
+                                     $SIPtest::field_specs{(FID_PRINT_LINE)},
+                                     { field    => FID_PATRON_ID,
+                                       pat      => qr/^djfiander$/,
+                                       required => 1, },
+                                     { field    => FID_ITEM_ID,
+                                       pat      => qr/^1565921879$/,
+                                       required => 1, },
+                                     { field    => FID_TITLE_ID,
+                                       pat      => qr/^Perl 5 desktop reference$/,
+                                       required => 1, },
+                                     { field    => FID_DUE_DATE,
+                                       pat      => qr/^$datepat$/,
+                                       required => 1, },
+                                     { field    => FID_SECURITY_INHIBIT,
+                                       pat      => qr/^[YN]$/,
+                                       required => 0, },
+                                    ],};
 
 my @tests = (
             $SIPtest::login_test,
@@ -64,6 +79,18 @@ $test->{msg} =~ s/AB1565921879\|/AJPerl 5 desktop reference|/;
 # Everything else should be the same
 push @tests, $test;
 
+# Renew: Item checked out, but another patron has placed a hold
+$test = clone($renew_test_template);
+$test->{id} = 'Renew: Item has outstanding hold';
+$test->{pat} = qr/^300NUN$datepat/;
+foreach my $field (@{$test->{fields}}) {
+    if ($field->{field} eq FID_DUE_DATE || $field->{field} eq FID_TITLE_ID) {
+       $field->{pat} = qr/^$/;
+    }
+}
+
+push @tests, $hold_template, $test, $cancel_hold_template;
+
 # Renew: item not checked out.  Basically the same, except
 # for the leader test.
 $test = clone($renew_test_template);