LP#1596595 Hold copy permit test thinko repair
authorBill Erickson <berickxx@gmail.com>
Thu, 19 Jan 2017 17:21:11 +0000 (12:21 -0500)
committerKathy Lussier <klussier@masslnc.org>
Fri, 17 Feb 2017 05:58:53 +0000 (00:58 -0500)
Pickup and requesting org unit IDs were passed in the wrong order to
the copy permit test.  This resulted in some items, particularly age
protected copies, appearing on the holds pull list even though they were
not (yet) permitted for hold capture at a remoted library.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Open-ILS/src/perlmods/lib/OpenILS/Utils/HoldTargeter.pm

index 5555c86..125b395 100644 (file)
@@ -1043,8 +1043,8 @@ sub copy_is_permitted {
     my $resp = $self->editor->json_query({
         from => [
             'action.hold_retarget_permit_test',
-            $self->hold->request_lib,
             $self->hold->pickup_lib,
+            $self->hold->request_lib,
             $copy->{id},
             $self->hold->usr,
             $self->hold->requestor