lp1616170 SIP Items available subroutine respects is_available
authorKyle Huckins <khuckins@catalyte.io>
Wed, 15 May 2019 23:03:49 +0000 (23:03 +0000)
committerKyle Huckins <khuckins@catalyte.io>
Thu, 6 Jun 2019 16:19:14 +0000 (16:19 +0000)
- SIP Items.PM available subroutine checks for the is_available
field on a status

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/perlmods/lib/OpenILS/SIP/Item.pm

Open-ILS/src/perlmods/lib/OpenILS/SIP/Item.pm

index e727732..27fc053 100644 (file)
@@ -437,10 +437,8 @@ sub print_line {
 sub available {
     my ($self, $for_patron) = @_;
 
-    my $stat = $self->{copy}->status->id;
-    return 1 if 
-        $stat == OILS_COPY_STATUS_AVAILABLE or
-        $stat == OILS_COPY_STATUS_RESHELVING;
+    my $stat_is_available = $self->{copy}->status->is_available;
+    return 1 if $stat_is_available;
 
     return 0;
 }