Fix broken builds due to test that can't find its data
authorDan Scott <dan@coffeecode.net>
Thu, 28 Jul 2011 19:49:12 +0000 (15:49 -0400)
committerLebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Thu, 28 Jul 2011 19:57:38 +0000 (15:57 -0400)
LP 817699 reports a problem that began with commit
e9cd992fa4dbf1013346336193cb7469ecee10a8, reintroducing a problem that
had previously been resolved with commit
f017d1261c369b9b5cc3c9cfc4f50d3cdf12a445. In short, tests can and are
run from different directories, but a new test opened a file without
making any allowance that the test might be run from anything other than
the /test/ directory.

This fix uses the dirname(__FILE__) approach to provide the appropriate
relative directory for the test data, and enables the tests to be
processed without dying.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Open-ILS/src/perlmods/lib/OpenILS/Utils/MFHD/test/mfhd.t

index d9ad34b..29ee865 100644 (file)
@@ -66,7 +66,8 @@ while ($rec = testlib::load_MARC_rec($testdata, $testno++)) {
 close $testdata;
 
 # test: passthru_open_ended
-open($testdata, "<mfhddata2.txt") or die("Cannot open 'mfhddata2.txt': $!");
+my $testfile2 = dirname(__FILE__) . "/mfhddata2.txt";
+open($testdata, "<", $testfile2) or die("Cannot open '$testfile2': $!");
 
 $rec = MFHD->new(testlib::load_MARC_rec($testdata, $testno));
 my $rec2 = MFHD->new(testlib::load_MARC_rec($testdata, $testno));