LP887822 mint_condition/Quality not set correctly

during item creation.

Specifically, the Javascript object for a new item (acp) does not explicitly set
the mint_condition field, leaving it null. The item attribute editor treats the
null as false (which it displays as "Mediocre" for that field). The database has
a not null constraint the corresponding column in asset.copy, and defaults to
true. So a new item in the attribute editor will show "Mediocre", but when
actually created, will become "Good".

This branch just sets mint_condition to true when an item is created.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

diff --git a/Open-ILS/xul/staff_client/chrome/content/cat/opac.js b/Open-ILS/xul/staff_client/chrome/content/cat/opac.js
index f44aeae..7dd6357 100644 (file)
--- a/Open-ILS/xul/staff_client/chrome/content/cat/opac.js
+++ b/Open-ILS/xul/staff_client/chrome/content/cat/opac.js
@@ -200,6 +200,7 @@ function set_marc_edit() {
                             copy_obj.holdable(get_db_true());
                             copy_obj.opac_visible(get_db_true());
                             copy_obj.ref(get_db_false());
+                            copy_obj.mint_condition(get_db_true());
 
                             JSAN.use('util.window'); var win = new util.window();
                             return cat.util.spawn_copy_editor( { 'handle_update' : 1, 'edit' : 1, 'docid' : doc_id, 'copies' : [ copy_obj ] });

diff --git a/Open-ILS/xul/staff_client/server/cat/util.js b/Open-ILS/xul/staff_client/server/cat/util.js
index 7f7949a..e1530f8 100644 (file)
--- a/Open-ILS/xul/staff_client/server/cat/util.js
+++ b/Open-ILS/xul/staff_client/server/cat/util.js
@@ -565,6 +565,7 @@ cat.util.fast_item_add = function(doc_id,cn_label,cp_barcode) {
         copy_obj.holdable(get_db_true());
         copy_obj.opac_visible(get_db_true());
         copy_obj.ref(get_db_false());
+        copy_obj.mint_condition(get_db_true());
 
         JSAN.use('util.window'); var win = new util.window();
         JSAN.use('cat.util');

diff --git a/Open-ILS/xul/staff_client/server/cat/volume_copy_creator.js b/Open-ILS/xul/staff_client/server/cat/volume_copy_creator.js
index ac28aff..ff0d9b7 100644 (file)
--- a/Open-ILS/xul/staff_client/server/cat/volume_copy_creator.js
+++ b/Open-ILS/xul/staff_client/server/cat/volume_copy_creator.js
@@ -451,6 +451,7 @@ g.stash_and_close = function(param) {
             copy.holdable(get_db_true());
             copy.opac_visible(get_db_true());
             copy.ref(get_db_false());
+            copy.mint_condition(get_db_true());
             return copy;
         }