ForceExternal: Compare hostnames case insensitive user/bshum/mixed_case_hostname_2_2
authorThomas Berezansky <tsbere@mvlc.org>
Wed, 6 Feb 2013 21:01:49 +0000 (16:01 -0500)
committerBen Shum <bshum@biblio.org>
Wed, 13 Feb 2013 04:30:49 +0000 (23:30 -0500)
Lowercase both sides to avoid "right host, wrong case" issues.

Resolves LP1081699 where the external browser would be used due to
hostname case sensitivity.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/xul/staff_client/components/forceexternal.js

Open-ILS/xul/staff_client/components/forceexternal.js

index d93aaca..4c71684 100644 (file)
@@ -24,7 +24,7 @@ const myAppHandler = {
           var targetWindow = wm.getMostRecentWindow("eg_main");
           if (targetWindow != null) {
             var host = targetWindow.G.data.server_unadorned;
-            if(host && (contentLocation.scheme == 'http' || contentLocation.scheme == 'https') && contentLocation.host != host) {
+            if(host && (contentLocation.scheme == 'http' || contentLocation.scheme == 'https') && contentLocation.host.toLowerCase() != host.toLowerCase()) {
                 // first construct an nsIURI object using the ioservice
                 var ioservice = Components.classes["@mozilla.org/network/io-service;1"]
                                 .getService(Components.interfaces.nsIIOService);