PINES fix for old catalog hold email display

Problem: If a staff member uses the old/traditional catalog
through the 3.6 staff client to place a hold, the staff member's
email address displays rather than the patron. It still saved
correctly, just displayed wrong.

Fix: This blocks the display of the email address on the holds
page when using the staff client. It still displays to patrons
using the OPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

diff --git a/Open-ILS/src/templates-bootstrap/opac/parts/place_hold.tt2 b/Open-ILS/src/templates-bootstrap/opac/parts/place_hold.tt2
index d9894ff..e70e42a 100755 (executable)
--- a/Open-ILS/src/templates-bootstrap/opac/parts/place_hold.tt2
+++ b/Open-ILS/src/templates-bootstrap/opac/parts/place_hold.tt2
@@ -241,8 +241,9 @@ function maybeToggleNumCopies(obj) {
                 <input class="form-check-input" type="checkbox" value="t" id="email_notify" name="email_notify" [% IF !ctx.user.email %]disabled="true"[% ELSIF ctx.default_email_notify %]checked="checked"[% END %]>
                 <label class="form-check-label" for="email_notify">
                    [% l('Yes, by Email') %]
-
-                     [% IF !ctx.user.email and !ctx.is_staff; "<br/>" _ l('No configured Email address. See "My Account" for setting your Email address.'); ELSE; %] : <span id="email_address"><b>[% ctx.user.email %]</b></span>[% END %]
+                   [% IF !ctx.is_staff %] 
+                      [% IF !ctx.user.email; "<br/>" _ l('No configured Email address. See "My Account" for setting your Email address.'); ELSE; %]: <span id="email_address"><b>[% ctx.user.email %]</b></span>[% END %]
+                   [% END %]
                 </label>
             </div>